Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GitHub Action checkout #339

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Upgrade GitHub Action checkout #339

merged 1 commit into from
Mar 26, 2022

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Mar 20, 2022

@akaihola
Copy link
Owner

Hi @cclauss, thanks for the heads-up on this!

The build is failing due to the updated flake8-bugbear plugin complaining about our use of @lru_cache. This is being fixed in #340. Please wait for that to be merged (review appreciated!) and then rebase this one on top of master. That should fix the failure.

@akaihola akaihola added this to the 1.5.0 milestone Mar 21, 2022
@akaihola akaihola added the CI label Mar 21, 2022
@roniemartinez
Copy link
Collaborator

roniemartinez commented Mar 21, 2022

@akaihola You can use dependabot for module and actions update

@akaihola
Copy link
Owner

akaihola commented Mar 21, 2022

Last time I tried out dependabot it didn't understand setup.cfg files. Maybe that's fixed now? And I didn't know it does actions as well!

I actually tried to contribute a fix to support setup.cfg in dependabot/dependabot-core#2133, but my approach was not considered appropriate, and the issue is still open.

Oh, but now that I reviewed what happened back then, the big thing probably was that GitHub didn't run its integrated Dependencies Graph using dependabot anymore. So we may actually be talking about different things here @roniemartinez. I guess you're proposing to install and run dependabot in a GitHub Workflow, not about relying on GitHub's built-in dependency scanning?

@akaihola
Copy link
Owner

Thanks @cclauss and @brtknr!

@akaihola akaihola merged commit eef9571 into akaihola:master Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

4 participants